Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard add semicolon to beginning of onChange jsx callback #588

Closed
kasperpeulen opened this issue Aug 17, 2016 · 3 comments

Comments

@kasperpeulen
Copy link

commented Aug 17, 2016

        <FormControl
          type='text'
          value={exerciseId}
          placeholder='Enter exercise id'
          onChange={;(e) => dispatch(new Actions.ChangeExerciseId(e.target.value))} />
        {helpBlock}
        <FormControl.Feedback />

Look at the onChange callback.

@timoxley

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2016

But why

@dcousens dcousens added the question label Aug 18, 2016

@kasperpeulen

This comment has been minimized.

Copy link
Author

commented Aug 18, 2016

Context: I used standard-format package of atom. Before I formatted, there was no semicolon there, it also breaks the code.

@feross

This comment has been minimized.

Copy link
Member

commented Aug 18, 2016

The latest version of standard-format fixed this issue already. See: maxogden/standard-format#165

Anyway, I recommend using standard --fix going forward (once standard v8 is released), or you can try it out today using npm install standard@beta.

@feross feross closed this Aug 18, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.