Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0-beta class support is wonky #59

Closed
othiym23 opened this issue Mar 9, 2015 · 3 comments

Comments

@othiym23
Copy link

commented Mar 9, 2015 

bauchelain% standard --version
3.0.0-beta
bauchelain% standard
Error: Use JavaScript Standard Style (https://github.com/feross/standard)
  src/models/album-base.js:2:15: Missing space before function parentheses.
  src/models/album-multi.js:8:15: Missing space before function parentheses.
  src/models/album-multi.js:9:4: 'super' is not defined.
  src/models/album-multi.js:16:11: Missing space before function parentheses.
  src/models/album-multi.js:21:10: Missing space before function parentheses.
  src/models/album-multi.js:32:8: Missing space before function parentheses.
  src/models/album-multi.js:46:11: Missing space before function parentheses.
  src/models/album-single.js:4:15: Missing space before function parentheses.
  src/models/album-single.js:5:4: 'super' is not defined.
  src/models/album-single.js:15:11: Missing space before function parentheses.
  src/models/artist.js:2:15: Missing space before function parentheses.
  src/models/artist.js:8:18: Missing space before function parentheses.
  src/models/artist.js:12:11: Missing space before function parentheses.
  src/models/cover.js:4:15: Missing space before function parentheses.
  src/models/cover.js:12:11: Missing space before function parentheses.
  src/models/track.js:4:15: Missing space before function parentheses.
  src/models/track.js:20:11: Missing space before function parentheses.
  src/models/track.js:24:12: Missing space before function parentheses.
  src/models/track.js:32:12: Missing space before function parentheses.

As you can see, these are pretty standard uses of class syntax, and transpile without issue with babel. I haven't had the opportunity to dig in deeper and figure out what espree rules are causing these issues.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 9, 2015

Looks like an eslint bug. I opened an issue: eslint/eslint#1989
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 17, 2015

eslint fixed the issue! As of standard@3.0.0-beta4, this issue is fixed. 👍

@feross feross closed this Mar 17, 2015

@othiym23

This comment has been minimized.

Sign in to view
Copy link
Author

commented Mar 17, 2015

🎉
@yormi yormi referenced this issue Nov 27, 2015
Closed

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@othiym23 @feross
You can’t perform that action at this time.