Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard does not work well with should.js #591

Closed
bertolo1988 opened this issue Aug 18, 2016 · 2 comments

Comments

@bertolo1988
Copy link

commented Aug 18, 2016

This is my file:

/* global describe, it */
var FlightScrapper = require('../dist/flight-scrapper')
var Config = require('../config')
var should = require('should')

describe('FlightScrapper tests', function () {
  this.timeout(Config.TIMEOUT)

  it('should retrieve 15 results', function (done) {
    FlightScrapper.run().then(function (resp) {
      resp.should.be.exactly(15)
      done()
    })
  })
})

I keep getting :4:5: 'should' is defined but never used.
In order to avoid this i am adding a should.exist(resp).

Wich is not desirable.

@LinusU

This comment has been minimized.

Copy link
Member

commented Aug 18, 2016

Change var should = require('should') to require('should')?

@bertolo1988

This comment has been minimized.

Copy link
Author

commented Aug 18, 2016

oh. Makes sense, sorry. Thanks

@feross feross added the question label Aug 18, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.