Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support app node_modules #61

Closed
ahdinosaur opened this issue Mar 11, 2015 · 1 comment

Comments

@ahdinosaur
Copy link

commented Mar 11, 2015

we use the src/node_modules pattern in our apps (e.g. here and here), so the default ignore of **/node_modules/** doesn't work for us.

previous discussion in #35.

possible solutions already brought up:

  1. "we could ignore node_modules if a package.json is present in the same directory"
  2. implement a way to un-ignore a directory

1 makes a lot of sense, i don't see how it wouldn't work as the src/node_modules pattern as i understand it doesn't involve a src/package.json. keen to hear what people think, am happy to implement a PR for this.

@feross

This comment has been minimized.

Copy link
Member

commented Mar 12, 2015

Yeah, I actually think 1 would work. Happy to consider a PR for it.

feross added a commit that referenced this issue Apr 8, 2015

Only ignore root "node_modules" folder
This supports the "app node_modules pattern". Fixes #61.

@feross feross closed this in #107 Apr 9, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.