Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upShrinkwrap dependencies and remove carrots from package.json #654
Comments
This comment has been minimized.
This comment has been minimized.
|
Sorry your builds got broken. I do think that on the whole, having loose dependencies has been good for I think one improvement to the situation is to switch to |
feross
added a commit
that referenced
this issue
Oct 10, 2016
This comment has been minimized.
This comment has been minimized.
|
|
feross
closed this
in
#655
Oct 10, 2016
lock
bot
locked as resolved and limited conversation to collaborators
May 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
garretto commentedOct 10, 2016
Today eslint-plugin-react was updated and had bug - yannickcr/eslint-plugin-react@d0dfc07
This caused all of our builds to start failing since we npm install for every new build.
To fix this, I propose this package remove all carrots from dependency versions, e.g.
"eslint-plugin-react": "6.0.0",instead of"eslint-plugin-react": "^6.0.0",and include a shrinkwrap file - https://docs.npmjs.com/cli/shrinkwrapWe are now shrinkwrapping our dev dependencies at my company to prevent this issue in the future. But I think it'd be a good idea within this dependency as well for others.