Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upReferencing TypeScript definition files #660
Comments
krokofant
changed the title
TypeScript definition files
Referencing TypeScript definition files
Oct 12, 2016
feross
added
need more info
enhancement
labels
Oct 13, 2016
This comment has been minimized.
This comment has been minimized.
|
Can you link to the documentation where this If it's sufficiently common, I'm fine adding an exception for this. We already have a few exceptions for other tooling. |
This comment has been minimized.
This comment has been minimized.
|
Here is the TypeScript documentation for the |
This comment has been minimized.
This comment has been minimized.
|
@feross which exceptions do you refer to? iirc in hindsight the sentiment wasn't entirely favor of non-standard additions to standard (like JSX), even though it's been a huge drive in standard's adoption I feel that if this were to become a rule, it should be strict; e.g. only allow it for a leading comment on the first line - disabling comment validation in its entirety would probably be undesireable |
This comment has been minimized.
This comment has been minimized.
|
To add more to my opinion I want to use standard as it is a simple ruleset to adhere to but it's not usable if it hinders, and provides no alternative, to something that a developer sees as necessary. Regarding the format I just want something that works. |
This comment has been minimized.
This comment has been minimized.
|
@yoshuawuyts You can see the list of exceptions to the The point of
So, IMO, we should just allow it, especially if it's a directive used by popular tools. We already allow:
Note, a space is still required after the |
feross
removed
the
need more info
label
Oct 14, 2016
This comment has been minimized.
This comment has been minimized.
|
@feross fair point, ACK on this change |
feross
added this to the
standard v9 milestone
Jan 17, 2017
This comment has been minimized.
This comment has been minimized.
|
Okay, adding this to the |
feross
added a commit
to standard/eslint-config-standard
that referenced
this issue
Feb 9, 2017
This comment has been minimized.
This comment has been minimized.
|
This will be part of standard v9. Since this relaxes a rule, there is no ecosystem impact. |
krokofant commentedOct 12, 2016
To use definition files for libraries to provide IntelliSense is increasing.
I'd like to be able to use this as acceptable by standard
/// <reference path="jquery/index.d.ts" />Currently I get the