Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updo-while semicolon #678
Comments
This comment has been minimized.
This comment has been minimized.
|
Thanks for the issue, @bounceme. I don't have time to read that entire issue. Can you clarify what exactly you're proposing we do? |
feross
added
the
need more info
label
Nov 23, 2016
This comment has been minimized.
This comment has been minimized.
|
the semicolon is only necessary (browsers may behave differently) when not followed by a newline or |
This comment has been minimized.
This comment has been minimized.
|
if it is configurable with eslint, i think that missing a semi should give a warning |
This comment has been minimized.
This comment has been minimized.
|
There isn't an ESLint rule to enforce what you're asking for, so I'm going to close this issue. |
feross
closed this
Nov 23, 2016
This comment has been minimized.
This comment has been minimized.
|
@bounceme maybe open an eslint issue for it? |
bounceme commentedNov 9, 2016
mishoo/UglifyJS2#893
I think that the do-while is a exception and should have a semicolon to prevent inconsistent behaviour and dev confusion