Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments are intended after --fix #686

Closed
catx23 opened this issue Nov 15, 2016 · 1 comment

Comments

@catx23
Copy link

commented Nov 15, 2016

hi,
my comments went bad after --fix :

var Module = dcl([ModelBase, EventedMixin.dcl], {
    declaredClass: 'xblox.model.Scope',
    variableStore: null,
    serviceObject: null,
    context: null,
    blockStore: null,
        /**
         *  @type {module:xblox/model/Expression}
         */
    expressionModel: null,

is this a convention ? it does that to all comments in object literals:

          // console.error('auto blocks : '+autoBlocks.length + ' ' + this.id);
      for (var i = 0; i < autoBlocks.length; i++) {
        var block = autoBlocks[i]
        if (block.__started) {
                    // console.error('block already started');
        }
        if (block.enabled && block.start && block.startup && block.__started !== true) {
          block.start()
          block.__started = true
        }
      }

related

@feross

This comment has been minimized.

Copy link
Member

commented Nov 23, 2016

ESLint doesn't check comment indentation yet. There's an issue about it here: eslint/eslint#3845

We'll inherit the fix once it's resolved in ESLint.

@feross feross closed this Nov 23, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.