Disallow redundant return statements (no-useless-return)

[feross]

A return statement with nothing after it is redundant, and has no effect on the runtime behavior of a function. This can be confusing, so it’s better to disallow these redundant statements.

http://eslint.org/docs/rules/no-useless-return

[yoshuawuyts]

Yup, sounds good

On Tue, Nov 22, 2016 at 10:18 PM Feross Aboukhadijeh <
notifications@github.com> wrote:

A return statement with nothing after it is redundant, and has no effect
on the runtime behavior of a function. This can be confusing, so it’s
better to disallow these redundant statements.

http://eslint.org/docs/rules/no-useless-return

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#694, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWleky_IxPMCeyVGJlZdtWdJdXdxi34ks5rA1wMgaJpZM4K5861
.

[dcousens]

What about early exits?
Would:

if (!param) return

return 2 + 3

Still work?

Or

if (cond) {
  foo()
  return
}

bar()

[feross]

@dcousens Yep, those will still work. The rule only prevents useless returns like:

function foo () {
  if (cond) {
    console.log('hi')
    return
  }
}

[dcousens]

ACK then

[feross]

This will be part of standard v9. The ecosystem impact is 3 repos, with one statement in each requiring modification.