Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upValidate whitespace in and around the JSX opening and closing brackets (jsx-tag-spacing) #697
Comments
feross
added
the
enhancement
label
Nov 22, 2016
This comment has been minimized.
This comment has been minimized.
cpsubrian
commented
Dec 8, 2016
•
|
Just updated and noticed that
Also it seems inconsistent to then allow |
This comment has been minimized.
This comment has been minimized.
|
The hanging space did seem a bit odd, agreed with @cpsubrian . I personally hadn't thought about it. edit: Actually, it seems like it is an XML convention |
feross
added this to the
standard v11 milestone
Apr 4, 2017
feross
modified the milestones:
standard v12,
standard v13
Aug 28, 2018
feross
modified the milestones:
standard v13,
standard v14
Jul 5, 2019
This comment has been minimized.
This comment has been minimized.
|
This has actually been fixed for a while. Not sure what version it shipped in, but there's nothing to do here. |
feross commentedNov 22, 2016
Enforce or forbid spaces after the opening bracket, before the closing bracket of self-closing elements, and between the angle bracket and slash of JSX closing or self-closing elements.
{ "closingSlash": "never", "beforeSelfClosing": "always", "afterOpening": "never" }https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-tag-spacing.md
(Also, remove the deprecated
jsx-space-before-closingrule which is already enabled, but superceded byjsx-tag-spacingwhich is more complete)