Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `eslint-plugin-import` instead of `no-duplicate-imports` #712

Closed
ajhyndman opened this issue Dec 6, 2016 · 3 comments

Comments

@ajhyndman
Copy link

commented Dec 6, 2016

https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md

This is just a more robust implementation. The use-case I want to support is working with type definition imports, which must necessarily be separate but from the same source file as real imports.

e.g.

import MyComponent from 'components/MyComponent';
import type { Props } from 'components/MyComponent';
@cesarandreu

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2016

Right now this is probably the biggest pain-point with using standard with flow. This change would rock.

@feross

This comment has been minimized.

Copy link
Member

commented Feb 9, 2017

I hear you loud and clear 👍 Closing this as duplicate issue: #599

@feross feross closed this Feb 9, 2017

@feross

This comment has been minimized.

Copy link
Member

commented Mar 2, 2017

Just a heads up that this will be part of the standard v10 beta. See #599

feross added a commit to standard/eslint-config-standard that referenced this issue Mar 2, 2017

Add `eslint-plugin-import` for `import/no-duplicates` rule
Fixes: standard/standard#599
Fixes: standard/standard#712

`import/no-duplicates` replaces the core rule `no-duplicate-imports`.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.