Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule no-restricted-properties & no-restricted-globals? #716

Closed
davesnx opened this issue Dec 11, 2016 · 4 comments

Comments

@davesnx
Copy link

commented Dec 11, 2016

Hello @feross

I would like to discuss about adding this 2 properties on the standard config. I'm not sure if this is the right repo or I should open it on https://github.com/feross/eslint-config-standard

  • no-restricted-properties: disallow certain object properties
  • no-restricted-globals: disallow specific global variables

Basically, adds more options to make the linter capable to keep the code healty.
You seem worried about how many repos would you affect and adding this woudn't break anything, just adding a property on the package.json.

Thanks

@feross

This comment has been minimized.

Copy link
Member

commented Dec 27, 2016

@davesnx Sorry, it wasn't clear to me - are you proposing to allow standard users to configure the ESLint options you listed? standard intentionally doesn't support that kind of configuration. If that's what you're after, I suggest using ESLint directly with the eslint-config-standard configuration.

@feross feross closed this Dec 27, 2016

@davesnx

This comment has been minimized.

Copy link
Author

commented Dec 27, 2016

I was just proposing a new rule for https://github.com/feross/eslint-config-standard @feross

@feross

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

I'm still unclear what you're asking for. The http://eslint.org/docs/rules/no-restricted-properties rule for example lets you prevent certain property names from being used. What should standard set this to? If you want to configure this option to something specific for your codebase, then you can use eslint directly.

@dcousens

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

@davesnx just submit the PR.

It will likely answer all questions as to what you have written so far (as it isn't clear to me either).

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.