Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDuplicate errors when reassigning native globals #731
Comments
feross
added a commit
to standard/eslint-config-standard
that referenced
this issue
Jan 18, 2017
This comment has been minimized.
This comment has been minimized.
|
@nickmccurdy You're correct. We currently have both rules enabled. I'll disable the deprecated one. |
feross
added
the
bug
label
Jan 18, 2017
feross
closed this
in
standard/eslint-config-standard#65
Jan 18, 2017
This comment has been minimized.
This comment has been minimized.
|
This will go out in the next release of |
This comment has been minimized.
This comment has been minimized.
|
Cool, thanks! |
lock
bot
locked as resolved and limited conversation to collaborators
May 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
nickmccurdy commentedJan 3, 2017
•
edited
I have some test code that needs to reassign
globalbecause the implementation code is instrumenting the global scope with a DSL, but I don't want this to pollute my tests.According to eslint, this should be as simple as disabling
no-native-reassign, or the newno-global-assignwhich deprecates it. I would except that I would only need to disable one of these rules, butstandard -vproduces two errors for the same line, one for each rule. I would expect to only need to disable the latter. This looked like an issue withstandardto me, but I'll reopen this upstream if you think it's internal toeslint.Reproduction
With
standard@8.6.0:Expected
Actual
Workaround
Disabling a single rule doesn't work, you must disable both.