Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why we don't just use .editorconfig #732

Closed
GGYaX opened this issue Jan 4, 2017 · 6 comments

Comments

@GGYaX
Copy link

commented Jan 4, 2017

No need the comple xml configuration, it's works for other IDE.

@dcousens dcousens added the question label Jan 4, 2017

@feross

This comment has been minimized.

Copy link
Member

commented Jan 5, 2017

I'm not very familiar with .editorconfig, but it doesn't offer very many rules, it seems.

standard currently has at least 150 rules, including many that involve parsing the AST of the code in order to check for possible errors. This is, to my knowledge, beyond the scope of what .editorconfig can do.

@feross feross closed this Jan 5, 2017

@wesleytodd

This comment has been minimized.

Copy link

commented Feb 22, 2017

I think the idea here is not "fully supporting standard rules", it is that a few small things can be made easier on users who have to conform to multiple projects guidelines. So for example, the following file will nicely set my vim settings so a tab defaults to two spaces in my standard compliant projects, despite defaulting my editor to use tab characters normally:

# http://editorconfig.org
root = true

[*]
indent_size = 2
indent_style = space

Which is handy for people like me who use both happiness and standard on different projects.

See here for an example of this in action: https://github.com/wesleytodd/store-settings/blob/master/.editorconfig

@feross

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

@wesleytodd Thanks for explaining further. I don't see what's stopping you from adding an .editorconfig to your project though. I don't think it's the place of standard to add files to your project.

@wesleytodd

This comment has been minimized.

Copy link

commented Feb 22, 2017

Oh maybe I also miss-understood the OP. I actually ended up here because I was going to copy the .editorconfig for this project into mine :) But didn't find one, and searched issues. So my assumption was that the OP here was asking why not add an .editorconfig to this project. Anyway, looks like I was wrong.

@GGYaX

This comment has been minimized.

Copy link
Author

commented Feb 23, 2017

My idea was not about the rule. As I see in standard.xml in webstorm configuration, it can easily replaced by .editorconfig. And It can also be extended to other IDE.

@feross

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

Ah, I see. I'm happy to accept a PR that adds an .editorconfig file to the repo. Cheers.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.