Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all configs to use new "error" style #734

Closed
feross opened this issue Jan 7, 2017 · 5 comments

Comments

@feross
Copy link
Member

commented Jan 7, 2017

Right now our configs do this:

{
  "rule-name": 2
}

But this can be rewritten to:

{
  "rule-name": "error"
}

The latter is more readable.

@feross feross added the meta label Jan 7, 2017

@dcousens

This comment has been minimized.

Copy link
Member

commented Jan 7, 2017

Agreed

@joshuacolvin

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2017

I can take this one.

@feross

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2017

@joshuacolvin Actually, I think I should take this one, if you haven't started it yet. There are some pending rule change PRs that I need to merge for v9. They won't apply cleanly if we change every line of the config first. Hopefully you haven't started this yet.

@feross feross self-assigned this Jan 23, 2017

@joshuacolvin

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2017

No worries! I haven't started yet.

feross added a commit to standard/eslint-config-standard that referenced this issue Feb 8, 2017

feross added a commit to standard/eslint-config-standard-jsx that referenced this issue Feb 8, 2017

feross added a commit to standard/eslint-config-standard-react that referenced this issue Feb 8, 2017

@feross feross added this to the standard v9 milestone Feb 8, 2017

@feross

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2017

This is now resolved.

@feross feross closed this Feb 8, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.