Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert all configs to use new "error" style #734
Comments
feross
added
the
meta
label
Jan 7, 2017
This comment has been minimized.
This comment has been minimized.
|
Agreed |
This comment has been minimized.
This comment has been minimized.
|
I can take this one. |
This comment has been minimized.
This comment has been minimized.
|
@joshuacolvin Actually, I think I should take this one, if you haven't started it yet. There are some pending rule change PRs that I need to merge for v9. They won't apply cleanly if we change every line of the config first. Hopefully you haven't started this yet. |
feross
self-assigned this
Jan 23, 2017
This comment has been minimized.
This comment has been minimized.
|
No worries! I haven't started yet. |
feross
added a commit
to standard/eslint-config-standard
that referenced
this issue
Feb 8, 2017
feross
added a commit
to standard/eslint-config-standard-jsx
that referenced
this issue
Feb 8, 2017
feross
added a commit
to standard/eslint-config-standard-react
that referenced
this issue
Feb 8, 2017
feross
added this to the
standard v9 milestone
Feb 8, 2017
This comment has been minimized.
This comment has been minimized.
|
This is now resolved. |
feross
closed this
Feb 8, 2017
lock
bot
locked as resolved and limited conversation to collaborators
May 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
feross commentedJan 7, 2017
Right now our configs do this:
{ "rule-name": 2 }But this can be rewritten to:
{ "rule-name": "error" }The latter is more readable.