Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce more indentation rules #735

Open
feross opened this issue Jan 7, 2017 · 3 comments
Open

Enforce more indentation rules #735

feross opened this issue Jan 7, 2017 · 3 comments

Comments

@feross
Copy link
Member

feross commented Jan 7, 2017

Related to #628, there are more indent options that we should consider adding. Especially now that ESLint's indent rule has been completely rewritten to be stricter and better.

@feross feross added this to the standard v10 milestone Feb 9, 2017
@feross feross modified the milestones: standard v11, standard v10 Mar 2, 2017
@feross feross changed the title Enforce indentation for array and object literals, etc. Enforce more indentation rules Apr 8, 2017
@feross
Copy link
Member Author

feross commented Apr 13, 2017

The new indent rule implementation will ship in ESLint 4.0.0, so let's make whatever indentation changes we're going to make at the same time since there will already be some breaking changes since it's a new implementation that is stricter.

@Jessidhia
Copy link

The new indent shipped 🎉

Any thoughts on how the new indent setting will look like for standard? For example, one point I am wondering about is whether MemberExpression should be set to 1 or 0. At work we generally used the equivalent of 0.

// MemberExpression: 0
foo
.bar
.baz()
// MemberExpression: 1 (default)
foo
  .bar
  .baz()

@LinusU
Copy link
Member

LinusU commented Jun 14, 2017

I've seen 1 used more, and I think that is what I personally prefer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants