Disallow async functions which have no await expression (require-await)

[feross]

Async functions which have no await expression may be the unintentional result of refactoring. This rule warns async functions which have no await expression.

http://eslint.org/docs/rules/require-await

[not-an-aardvark]

It might be worth reviewing this discussion before adding this rule to Standard.

[feross]

@not-an-aardvark Good point. We actually didn't add require-yield to standard because, despite what that eslint issue thread says, there apparently are use cases for generators without yield, namely when interacting with third-party libraries that expect a generator. See #192 (comment)

For that reason, maybe we should also refrain from this rule, since it's very similar in spirit.

Those who upvoted, do you have any new thoughts? (@timoxley, @ifraixedes, @LinusU, @dougwilson)

[LinusU]

Hmm, that was actually very good points. I think I'm leaning towards not enabling this rule now :)

[junosuarez]

I would be against adding this to standard. I use async to mean "this function is gonna return a promise no matter what," not "I intend to use await in the body of this function."

[feross]

Thanks for the feedback @LinusU and @jsdnxx. Closing this for now.