Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Magic Numbers #757

Closed
Kikobeats opened this issue Jan 23, 2017 · 2 comments

Comments

@Kikobeats
Copy link

commented Jan 23, 2017

What do you think about this rule?

My start points are:

PROS

  • Magic numbers are too clever, use a name for avoid it is always helpful.

CONS

  • Maybe too restrictive related with the live cycle of the code.
@mafintosh

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 23, 2017

👎 - Plenty of use cases for inlining numbers (file permissions etc)

@dcousens dcousens added the enhancement label Jan 23, 2017

@yoshuawuyts

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 23, 2017

@feross feross closed this Feb 9, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
5 participants
@Kikobeats @mafintosh @yoshuawuyts @feross @dcousens
You can’t perform that action at this time.