fix code style badge markdown

[callmecavs]

noticed in trying to add the code style badge (the shields.io one) to some of my READMEs that copy/pasting the code on the README doesn't work.

GitHub seems to get tripped up on the URL encoded space - replacing the %20 encode with an _ yields the same text, and fixes the badge embed.

Submitted a PR too: #761

[yoshuawuyts]

Noticed this too today, I think given the wide spread use of this badge it should probably either be brought up with shields.io or GitHub support

…

On Tue, Jan 24, 2017, 16:21 Michael Cavalea ***@***.***> wrote: noticed in trying to add the code style badge (the shields.io one) to some of my READMEs that copy/pasting the code on the README doesn't work. GitHub seems to get tripped up on the URL encoded space - replacing the %20 encode with an _ yields the same text, and fixes the badge embed. Submitted a PR too: — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#760>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWlepmyQeyLMd-rzPFYIMeSI2RJhL0Bks5rVhcSgaJpZM4LsZJH> .

[feross]

Thanks for the PR, merged it. I wasn't able to reproduce the issue, though. Maybe it was a transient issue? Can you check and see if %20 still causes problems for you?

[callmecavs]

@yoshuawuyts @feross still seeing the problem on my end - also not seeing es6 work for codeblock highlighting on README's anymore (though javascript correctly highlights ES6 syntax now) either. noticed it around the same time as I noticed the badges issue

[feross]

@callmecavs Do you have a link to a readme that exhibits the issue?

Sounds like they updated the version of https://github.com/github/markup ?

[callmecavs]

@feross highlighting is broken here, and code style badge broken here for me (incognito, no extensions)

agreed that it might be a markdown change - maybe a highlight.js version bump broke the syntax highlighting? i could see the es6 being deprecated/removed as it was stabilized and integrated into javascript. only like 50% sure github uses it tho

[feross]

The badge is not broken for me in Chrome Stable. See:

What is the http response codes that you get for the following URLs?

1. https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat-square
2. https://camo.githubusercontent.com/60b623caed11e738da0b201abab8b8d2de66a7b0/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f636f64652532307374796c652d7374616e646172642d627269676874677265656e2e7376673f7374796c653d666c61742d737175617265 (github's cached version)

[dougwilson]

Many shields io badges have a space. I have been seeing over the past week at least github flipping between them broken and not broken. I assume this is a general github issue.

[callmecavs]

@feross @dougwilson getting random 504's on some cached badges - looking at the choo repo again, now its the npm badge. could be related to GitHub caching, changing to an _ might just be busting the cache (not sure if chrome encodes the url before or after hitting enter)? likely not related to the standard badge I think we can say at this point

[feross]

I've reached out to GitHub support on Twitter. Closing this, as it's not a standard issue.

[feross]

@callmecavs GitHub is asking if you can open an issue about this here http://git.io/c

[callmecavs]

@feross i opened one yesterday when I pinged GitHub on twitter about it, ill submit another in a bit

[feross]

No worries if you already opened an issue

[callmecavs]

will let you known when i hear back