Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force using parens around single argument on arrow functions? #790

Closed
tunnckoCore opened this issue Feb 20, 2017 · 4 comments

Comments

@tunnckoCore
Copy link

commented Feb 20, 2017

I kinda like it more. It says more that this thing is a function.

force using

const foo = (abc) => 123

instead of

const foo = abc => 123

Currently, both styles are allowed. The reason I want that is, because it seems that ESLint fix does not remove them if you set them, but prettier seems to respect the second style more.

I'm kinda trying to start using Atom. And I have maybe kinda strange config:

  • Atom Linter
  • Atom Linter-ESLint
  • standard as devDependency
  • npm lint script that use that standard cli (mainly for contributors that dont have such editor config)
    • mainly for contributors that dont have such editor config, because that config flow just does not allow me to push wrong code at repo, hehe
  • eslingConfig field in package.json that has extends: standard to allow LinterESLint to do autofix
    • yea it may looks kinda strange that you have standard cli and also have eslintConfig field
    • another cool benefit from that is that contributors can use their global eslint cli if they want
  • Atom Prettier-ESLint plugin - that respects that eslintConfig and formats the code with it.

I kinda think that it is okey to do that change since v9 is upcoming. Not sure for the impact on the community, but please @feross at least try the tests to see the results - i'm curious :) Or maybe it can land for v10.

@timoxley

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2017

Previous related discussion: #414, #309

@tunnckoCore

This comment has been minimized.

Copy link
Author

commented Feb 20, 2017

Thanks.

Hm. It seems it was landed, but later is completely removed? Because I can't see it in the config currently?

@dcousens

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

NACK

@feross

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

Closing this, as this was previously decided in #414. I don't think there's a compelling reason to revisit this discussion at this time.

@feross feross closed this Apr 4, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.