Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upProposal: Disallow await in loops #793
Comments
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Maybe. I believe we should run tests, to see ecosystem impact and if it is not so big everyone can add disable comment. |
This comment has been minimized.
This comment has been minimized.
|
Duplicate: #737 Please use search before creating new issues. |
feross
closed this
Feb 21, 2017
lock
bot
locked as resolved and limited conversation to collaborators
May 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tunnckoCore commentedFeb 21, 2017
Digging more and more in ESLint rules, i found some good ones which enforces good style and more readable code. This issue is for no-await-in-loop rule - not fixable.
Suggested configuration.
{ "no-await-in-loop": "error" }I believe it is good practice to not do that and ban such things, since each loop iteration is delayed until the entire asynchronous operation completes.