Proposal: one statement per line

[tunnckoCore]

Digging more and more in ESLint rules, i found some good ones which enforces good style and more readable code. This issue is for max-statements-per-line rule - not fixable.

Suggested configuration.

{
  "max-statements-per-line": ["error", { "max": 1 }]
}

Invalid

var bar; var baz

if (condition) bar = 1; if (condition) baz = 2

for (var i = 0; i < length; ++i) { bar = 1 }

switch (discriminant) { default: break }

function foo () { var bar = 1 }

Valid

var bar, baz

if (condition) bar = 1

for (var i = 0; i < length; ++i);

switch (discriminant) { default: }

function foo () { }

Semicolon in for is required, since it will be autofixed by other rule to

for (var i = 0; i < length; ++i) { switch (discriminant) { default: } }

[dcousens]

ACK, provided the following is possible:

for (var i = 0; i < length; ++i) bar++

[tunnckoCore]

Yea it is, that's good example too.

[timoxley]

I think this is decent. Interested in ecosystem impact.

[ghost]

FWIW, in CoffeeScript, I write my early terminations like unless bar; return. IMHO the more "rules" we pile into Standard the less portable it becomes. And I get CoffeeScript lacks hype any longer, but please note it's the primary authoring language of Framerjs and a great way to get designers coding.

[feross]

This rule would disrupt the way that too many people write code and it doesn't prevent bugs or improve code consistency enough to justify the cost to users, in my opinion.

Here are the results of the test suite: 24% breakage.

# tests 238
# pass  182
# fail  56

[dcousens]

@feross what were some of those failures? OOI

[yoshuawuyts]

I'm assuming for-loops would be a big part of this

…

On Wed, Apr 5, 2017 at 3:19 AM Daniel Cousens ***@***.***> wrote: @feross <https://github.com/feross> what were some of those failures? OOI — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#798 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWleqtzrMdl9-BvQFqcDykCS5fbX90mks5rsuwFgaJpZM4MHuWA> .

[feross]

@dcousens I can't remember... From memory, things like:

if (condition) { foo() } else { bar() }

And certain for loops.