Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWhat is the effect of making `lintText` synchronous? #807
Comments
feross
added
the
question
label
Mar 2, 2017
feross
added this to the
standard v11 milestone
Mar 2, 2017
This comment has been minimized.
This comment has been minimized.
tunnckoCore
commented
Mar 2, 2017
that's the right move for me, because in any way it is totally sync process. Cost nothing to support both style APIs here, since standard is higher level api on top of ESLint and StandardEngine. Won't be good to revert it in standard-engine. Support both - I call such APIs "hybrids". |
feross
added a commit
to standard/standard-engine
that referenced
this issue
Apr 4, 2017
feross
closed this
in
standard/standard-engine#159
Apr 4, 2017
This comment has been minimized.
This comment has been minimized.
|
Rather than make the
|
feross commentedMar 2, 2017
In
standard-engine6.0.0, thestandard.lintTextmethod was changed to be sync instead of async.From the changelog:
How will this change effect the various editor plugins? I don't want the editor plugins to have to detect the version of
standardin use in order to call the method correctly.Let's find out what the effect of this is, and if it's an annoying change, we can either revert, or make the method work the same as before if a callback is passed in.