Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strings and template string expressions #841

Closed
robertkowalski opened this issue Apr 7, 2017 · 1 comment

Comments

@robertkowalski
Copy link

commented Apr 7, 2017

hey folks,

standard 10.0.1 thinks that a string with a ${} is a template literal and it feels like a bug to me:

this code:

      const config = [
        '# Switch to false to enhance the performance of the javascript generation and similar',
        'magnolia.develop=false',
        'magnolia.resources.dir=${magnolia.home}/logs'
      ].join('\n')

(note the ${magnolia.home}/logs')

gets an error with:

 /Users/robert/magnolia/npm-cli/test/editMagnoliaPropertiesTest.js:20:9: 
Unexpected template string expression.
@feross

This comment has been minimized.

Copy link
Member

commented Apr 7, 2017

This is an intentional rule – it's designed to catch accidental usage of ' when ` was intended. If your usage is intentional, then you can simply disable the rule as described in the readme.

@feross feross closed this Apr 7, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.