Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRelax rule: import/no-absolute-path #861
Comments
This comment has been minimized.
This comment has been minimized.
|
Confirmed a noticable (150-200ms) improvement on a real-world repo ( Before:
After:
|
feross
closed this
in
standard/eslint-config-standard@6ffbd1f
Apr 14, 2017
Flet
reopened this
Apr 14, 2017
Flet
closed this
Apr 14, 2017
This comment has been minimized.
This comment has been minimized.
|
Released as 10.0.2 |
lock
bot
locked as resolved and limited conversation to collaborators
May 10, 2018
standard
unlocked this conversation
Jul 28, 2019
This comment has been minimized.
This comment has been minimized.
|
This rule will be re-enabled in standard v14 since the performance issues with it have been fixed now See: #1343 |
feross
modified the milestone:
standard v14
Jul 28, 2019
feross
added a commit
that referenced
this issue
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
feross commentedApr 14, 2017
I would like to relax the
import/no-absolute-pathrule which "Forbids import of modules using absolute paths". It's not that I think absolute imports are a good idea, it's just that this rule is incredibly slow!I opened an issue about it on the
eslint-plugin-importrepo: benmosher/eslint-plugin-import#803Almost 25% of linting time is spent in that one rule. Since this isn't actually a very common error (0 repos in our test suite actually failed when this was added, it's no big deal to just remove it, IMO)
Here's the raw output: