Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VariableDeclarator ? #869

Closed
muhajirdev opened this issue Apr 26, 2017 · 3 comments

Comments

@muhajirdev
Copy link

commented Apr 26, 2017

consider this

screenshot from 2017-04-26 14-32-23

wouldn't it be nice if we just write like this

screenshot from 2017-04-26 14-30-39

But i got error no-multi-spaces when i wrote code like that.
We can implement that with no-multi-spaces' exception VariableDeclarator.
http://eslint.org/docs/rules/no-multi-spaces#exceptions

@dcousens dcousens added the question label Apr 26, 2017

@LinusU

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

I think that the problem with this is the horrible git diffs that you get when adding one slightly longer variable. Then you have to go back and change all the previous lines to match.

Also, I personally don't think that standard should allow both, either this should be required or not allowed...

@feross

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

Sorry, this kind of manual variable alignment is not really the best use of limited programmer time, even though I agree that it arguably looks "pretty".

Better to have a consistent rule: always type one space.

@feross feross closed this Apr 26, 2017

@Flet

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

fixed?
image

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.