Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links inside translation documents #908

Closed
ematipico opened this issue Jun 1, 2017 · 1 comment

Comments

@ematipico
Copy link
Contributor

commented Jun 1, 2017

Hi team!

I was starting to work on a translation of the documentation of the project in italian.
While I was following the current translations to have an idea on how to contribute, I noticed that the links inside the foreign translations (I checked spanish, portugues and chinese so far) point to the english version.

You can try to go there https://standardjs.com/readme-esla.html and click the link "Más detalles". I haven't checked all the links - of course, but I think most of them are broken

@ematipico ematipico referenced this issue Jun 9, 2017
@feross

This comment has been minimized.

Copy link
Member

commented Jun 21, 2017

Excited to see your Italian translation! 🇮🇹

Thanks for letting us know about the broken links. There might be a way to fix this in the build process for the website. @Flet - thoughts?

Otherwise, I think we should make a folder for each translation, esla, ptbr, zhcn, etc. and put the README.md and RULES.md for that language in there. That would make the relative links between README.md and RULES.md work correctly within a given translation.

We should also probably consider adding the list of translations to the header in the build script since it's a burden to update it in every translation when there's a new translation added.

@ematipico ematipico closed this Jul 8, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.