Unusual yoda expressions

[dcousens]

I recently had a case where I was using the following code in a test:

{
  a: true,
  b: false,
  c: 1 > 2
}

Standard blew up on me with Expected literal to be on the right side of >.
Apparently this is due to it attempting to adhere a yoda condition ruling.

Is this intentional?

I understand this is most likely a question for eslint, not standard, but I thought I'd ask first.

[feross]

It seems that eslint considers any expression where the left side is a constant to be a "yoda expression". That seems okay behavior to me, though the error is a bit misleading in this case.

[dcousens]

So @feross we think its acceptable to not allow constant expressions? That's ridiculous no? Its a perfectly valid case of something you might want?

[feross]

@dcousens Constant expressions are still allowed, of course :-) For example: var x = 'my string' and var y = 42.

One side effect of the "no yoda expressions" rule is that comparison expressions that always evaluate to the same thing (like 1 > 2) should just be inlined. Is there a reason why you can't change the test code to:

{
  a: true,
  b: false,
  c: false
}

[feross]

Btw, I don't actually think that preventing constant comparisons like 1 > 2 is very important - happy to turn that off if there's a way to do so.

If anything, eslint should make it a separate rule from the yoda expressions one, which is a bit more useful. Have you filed a bug on eslint?

[dcousens]

@feross I personally don't see any difference between: 2 < 1 and 2 + 1. In my mind they are both constant expressions, and yet the former is being picked up as erroneous.

I was thinking of pushing this bug upstream to eslint, just figured I'd ask here first.

[feross]

Ah, you're right. If 1 + 2 is allowed, then 2 < 1 should be too. This is an eslint bug, in my opinion.

[dcousens]

@feross did we file this in eslint? If not, I'll assign it to myself for now as a reminder.

[feross]

@dcousens I don't remember filing this on eslint.

[feross]

@dcousens Did you ever file this bug on eslint?

[dcousens]

@feross I haven't yet, no.

[feross]

Bug filed on eslint: eslint/eslint#2867

[feross]

Bug fixed on eslint master.

[feross]

This is fixed in eslint 0.24.1. Run npm update to get the fix.