Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up'javascript:' in string bug #97
Comments
This comment has been minimized.
This comment has been minimized.
|
Looks like this came up as an issue on the eslint side too: Suggested fix was:
|
This comment has been minimized.
This comment has been minimized.
|
@jprichardson Out of curiosity, what were you trying to do where this rule was an issue? |
This comment has been minimized.
This comment has been minimized.
|
@feross Sure, cleaning up this old project: https://github.com/jprichardson/node-linkscrape Specifically, this file https://github.com/jprichardson/node-linkscrape/blob/master/lib/linkscrape.js It seems to me that this behavior is pretty odd and unexpected, specifically in the context of Node.js (albeit rare). Would it make sense for |
This comment has been minimized.
This comment has been minimized.
|
Heh its the exact same use case in that eslint issue... Interrogating a string. |
This comment has been minimized.
This comment has been minimized.
|
Agreed. This is a bit odd. |
jprichardson commentedApr 1, 2015
Consider this simple app:
Causes
standardto report: