Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDisallow the use of `only` in mocha tests #988
Comments
This comment has been minimized.
This comment has been minimized.
|
Would personally love this, too easy to accidentally commit this |
This comment has been minimized.
This comment has been minimized.
|
This is neat! However, I'd be a little worried that this could open the door to adding lots of framework/library specific rules, which could get hairy. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, that is very true, might be a good idea to think about where to draw the line, and this could potentially be on the wrong side of that line :) Although mocha is very widely used... |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Useful, but I don't know if this should be |
dcousens
added
the
feature request
label
Sep 25, 2017
This comment has been minimized.
This comment has been minimized.
blgm
commented
Oct 12, 2017
|
The best way that I've found to avoid committing Jasmine uses |
This comment has been minimized.
This comment has been minimized.
|
I don't think this belongs in |
feross
closed this
May 3, 2018
This comment has been minimized.
This comment has been minimized.
Janpot
commented
May 4, 2018
|
If I recall correctly, mocha has a |
owennicol commentedSep 18, 2017
Could we add in a rule for not allowing
onlyin mocha tests please?This is an ESLint plugin for the same thing if that helps: https://www.npmjs.com/package/eslint-plugin-mocha-no-only