Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standard-format. fixes #340 #397

Closed
wants to merge 1 commit into from

Conversation

4 participants
@mafintosh
Copy link
Contributor

mafintosh commented Feb 1, 2016

With this PR standard has around 250 fewer dependencies when installing.

@yoshuawuyts

This comment has been minimized.

Copy link
Contributor

yoshuawuyts commented Feb 1, 2016

haha, lgtm

@dcousens

This comment has been minimized.

Copy link
Member

dcousens commented Feb 2, 2016

@mafintosh does this break standard --format?

@feross

This comment has been minimized.

Copy link
Member

feross commented Feb 3, 2016

@dcousens Yes, it will. We're going to recommend that folks install standard-format separately from now on. The dependencies for standard-format are just too many and it makes install take way too long, even more-so with npm 3. It's not the fault of standard-format. Auto-formatting is complicated and esformatter is just a heavy dependency.

@feross

This comment has been minimized.

Copy link
Member

feross commented Feb 3, 2016

@mafintosh This looks good, but I want to print a friendlier message to people who run standard --format in the new version. Maybe something like:

Code formatting is available in a standalone package: "standard-format". To install it, run "npm install -g standard-format".

@feross feross added the v6 label Feb 3, 2016

@dcousens

This comment has been minimized.

Copy link
Member

dcousens commented Feb 3, 2016

ACK 👍

@feross

This comment has been minimized.

Copy link
Member

feross commented Feb 4, 2016

This has been merged into the v6 branch.

@dcousens dcousens closed this Feb 4, 2016

@feross feross referenced this pull request Feb 4, 2016

Closed

Release proposal: standard v6 #399

25 of 25 tasks complete

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.