(fix) GCC array bounds checking complaint #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 12.2 is not convinced that dir will never be empty. Since that's an exceptional situation that seems almost impossible to happen, I'm throwing an exception here. Fixes standardese#160
foonathan
requested changes
Feb 5, 2023
Collaborator
foonathan
left a comment
foonathan
left a comment
There was a problem hiding this comment.
Thanks, but I disagree about the fix.
src/libclang/libclang_parser.cpp
Outdated
| return file; | ||
| if (dir.empty()) | ||
| // should never happen, but GCC 12.2 is not convinced. That's what exceptions are for, isn't it? | ||
| throw std::invalid_argument("Either file is absolute or relative to some named dir"); |
Collaborator
There was a problem hiding this comment.
No, that's what assertions are for ;)
Please assert instead at the beginning of the function.
Contributor
Author
There was a problem hiding this comment.
Assertion was not enough, so I had to place a #pragma. Not as beautiful but at least one can easily spot that the line would be unreachable if dir was empty (unless clever users decides to disable the asserts, then they would be on their own luck :) )
A pragma was necessary, though. GCC up to 12.2 cannot understand the macro DEBUG_ASSERT would have stopped the execution before the suspected line.
CarlosNihelton
force-pushed
the
fix-gcc-abc
branch
from
7e34880 to
79bed01
Compare
Collaborator
|
I didn't like the pragma, so I've just decided to support empty paths. Thanks for the PR, but it was quicker to do it myself :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 12.2 is not convinced that
dirwill never be empty.Since that's an exceptional situation that seems almost impossible to happen, I'm throwing an exception here.
Fixes #160