New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching word doesn't highlight text for notes using an editor extension #415

Open
edzed42 opened this Issue Jan 4, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@edzed42
Copy link

edzed42 commented Jan 4, 2019

Search text feature acts weird with notes that have an editor installed on windows app. (Haven't tested this on mobile).

Searching for a word will find the notes that have that word, but it won't highlight that word inside the note if it has an editor. (Doesn't work with Advanced Markdown or Simple task from what I've tried.) This is not the case for notes that don't use an extenstion editor.

Let me know if anything I've written is unclear!

@mobitar

This comment has been minimized.

Copy link
Member

mobitar commented Jan 6, 2019

Indeed, this is a tricky issue. You'll find that sometimes it does. Actually, I've now realized something after testing it real quick. Results will be highlighted if the editor is currently loaded and active. However, if you switch to another editor, results will not be highlighted. I think we can fix this by just redoing the search behind the scenes whenever a new editor loads. I've made a note of this and hope to dig in more soon.

@edzed42

This comment has been minimized.

Copy link

edzed42 commented Jan 6, 2019

Oh interesting! I have different notes I tend to swap between that use different editors, so I'm not sure if even just opening and closing a note from another with a different editor is also a part of that bug.

Glad to hear that a solution seems possible! Should I close this issue? Or do I wait until whenever that update comes up to close it?

@mobitar

This comment has been minimized.

Copy link
Member

mobitar commented Jan 7, 2019

You can leave it open, I'll hopefully update this thread after the fix. Btw, as a workaround, you can just focus into the search field, then immediately press enter, and it will rehighlight the page. Do this if you're switching between notes with editors after you've performed a search.

@edzed42

This comment has been minimized.

Copy link

edzed42 commented Jan 8, 2019

Sounds good. And thank you for the workaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment