Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Global search #525

Open
chdezmar opened this issue Apr 18, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@chdezmar
Copy link

commented Apr 18, 2019

Global search vs Tag search would be a great addition.
I always find myself clicking 'All notes' to be able to search globally. It is pretty annoying when you can't find what you are looking for if you have a ton of tags because you are currently in a specific Tag,

WDYT?

@mobitar

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@chdezmar I think the best way to view the current search bar is to call it "simple search bar". In the future, we might benefit from making that area extensible, so we can easily create extensions like "Advanced Search Bar". It's such a subjective area in terms of how people want and expect it to behave that making it extensible might be the best solution. But we're still quite a way from that.

@chdezmar

This comment has been minimized.

Copy link
Author

commented Apr 18, 2019

@mobitar thanks for the quick reply. But maybe just a simple checkbox that would focus your search to the currently selected tag would be enough?

I can't think of any use cases for an 'Advanced Search Bar', since you can already sort by a a few options.

btw loving this project :)

@mobitar

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

I do agree that it sounds simple, but a "simple check box" here and a simple check box there and all of a sudden you find yourself swimming in unmanageable bloat. It's been a really long time since we added any new core features (Privileges perhaps being the last), so I'm just very careful in general about introducing new features and new UI, no matter the utility.

All that to say, hang in there—I'm sure we'll get this utility in one way or another ;)

@virtuallyvlad

This comment has been minimized.

Copy link

commented Apr 20, 2019

Would be nice to have more visual indication that you are searching only within a tag. I've frequently come up short searching for a bunch of terms only to later realize -- d'oh! -- I had a tag clicked the whole time.

Most apps put some indication within the search bar itself or directly underneath, but do understand the concerns around anti-bloat and new UI elements.

@mobitar

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

I would have thought that it saying the tag name with a search box under it would be a sufficient visual indicator that you're in that context. The Mail.app on macOS for example behaves similarly. The global search box only searches the context you're in, without really telling you that's what it's doing.

@virtuallyvlad

This comment has been minimized.

Copy link

commented Apr 21, 2019

Perhaps it's the grayscale tones that cause these elements to blend more into the background. I guess I'm used to contrasting/highlighting contextual elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.