Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicted copies happen even when only using phone #615

Open
timgalebach opened this issue Jun 14, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@timgalebach
Copy link

commented Jun 14, 2019

When using my phone client on a connection with intermittent access, I frequently end up with conflicted copies. I assume this shouldn't happen if I'm only on one device?

Steps to reproduce: edit a note several times over the course of an hour or so, generally in a location with spotty internet access (gym, concrete building, etc).

@mobitar

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

What version of the app is this with, and what OS?

@timgalebach

This comment has been minimized.

Copy link
Author

commented Jun 14, 2019

3.0.10, on iOS

@mobitar

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

I tested typing for about 5 minutes on a network that simulates 3G speeds. Was unable to produce conflicts. Would you say your network was really slow, or it would drop requests all together at some point and show an error saving?

@timgalebach

This comment has been minimized.

Copy link
Author

commented Jun 14, 2019

It would drop requests altogether at times. It seems like that shouldn’t be an issue if all editing is on one client though, no?

I LOVE Standard Notes and am a subscriber, so this isn’t a deal breaker by any means. Just an annoyance that comes up a decent amount.

@mobitar

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Well, conflicts are created based on if the item you're trying to save has the same timestamp as what the server has. If requests are being dropped, then it may be that the server begins to have different timestamps than the local value, thus causing conflicts in future saves. This would seem to happen if the server successfully performs a save but the client drops the response that would keep its item in sync.

@timgalebach

This comment has been minimized.

Copy link
Author

commented Jun 17, 2019

Yeah, that’s likely the cause. Wouldn’t the more intuitive behavior be to check whether the client copy is a fast-forward of the parent copy, in a git sense?

@mobitar

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

We don't really track revisions on the client or server. It's just 1 final copy of the item we hang on to.

@mobitar mobitar transferred this issue from standardnotes/mobile Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.