Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus Editor: Line height not working as expected #655

Open
sethmad opened this issue Aug 9, 2019 · 2 comments

Comments

@sethmad
Copy link

commented Aug 9, 2019

In Plus Editor, the line height tool doesn't work as expected when dealing with multiple paragraphs. Because the line spacing is styled by the <p> tag, it is currently impossible to have no space between paragraphs.

For example, if line spacing is set to 1, a wrapped string of text will have no spacing between lines as expected. However, a new paragraph will automatically have spacing above.

In other words, in Plus Editor
you can't have multiple paragraphs
with no spacing between them
like this.

@mobitar

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

The Plus and Bold editors use <p> tags to display paragraphs, and I don't think there's any way for p tags to not have margins, unless you customize the CSS. But that would be outside the scope of the individual editors.

@sethmad

This comment has been minimized.

Copy link
Author

commented Aug 12, 2019

Correct, the <p> tag problem was noted in my original post but hidden by a typo. I believe the editor should be modified not to use <p> tags, because it limits styling and causes problems as the one mentioned in my original post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.