Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] File can be attached to a locked note #671

Open
MorgothSauron opened this issue Aug 23, 2019 · 2 comments

Comments

@MorgothSauron
Copy link

commented Aug 23, 2019

I have locked a note for testing. I cannot modify the note content itself, which is expected, but I'm still able to attach or delete a file. I was expecting an error when trying to attach a file.

@mobitar

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

Hmm..the thing is, attaching a file doesn't modify the note directly. It creates a separate file object that points to the note. So the note is completely untouched. But I can see how this can be confusing. I think for consistency we should indeed add a check so that attachments aren't allowed on locked notes.

@MorgothSauron

This comment has been minimized.

Copy link
Author

commented Aug 25, 2019

Hmm..the thing is, attaching a file doesn't modify the note directly. It creates a separate file object that points to the note. So the note is completely untouched. But I can see how this can be confusing. I think for consistency we should indeed add a check so that attachments aren't allowed on locked notes.

You got a good point: the content of the note itself is not modified. Maybe I was a little too quick with the "bug" label. I was just testing locked note and I wanted to see what happens when adding file ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.