Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with "Conflicted Copy" notes + tags and note history #678

Open
bschlagel opened this issue Aug 30, 2019 · 2 comments

Comments

@bschlagel
Copy link

commented Aug 30, 2019

Just experienced a weird/disconcerting issue with five copies of a note being created with the "Conflicted Copy" badge.

This is a note that I was editing on my iPhone while traveling. It seemed to be syncing fine via mobile data, though possible I closed the app before it finished syncing or something. When I got home I opened the app on my phone again and noticed all the duplicate "Conflicted Copy" notes. I opened the Mac desktop app and saw the same thing. The actual "Conflicted Copy" badge disappeared after I opened the notes, but all five duplicates are still in the notes list.

The note in question wasn't edited in a way where there should be unresolvable diffs. It's simply a list that I added more items to. Nothing deleted or edited. So there are now five copies, with the newer ones just having more text added at the top of the note. (A bit confusing in the first place as I'd expect all these dupes could be merged automatically.)

Another odd thing here: not all the copies have tags. The oldest one has the correct tags. The next one has no tags. The two after that have the correct tags. The newest one (only a single line of text different from the previous one) has no tags. So, there may be a bug here related to tags?

Similarly, could be an issue related to "Note History Action Menu", noticed something unexpected here as well. The second newest note is the one with the full "note history", i.e. seems this is the "real" or "original" note. The newest one in the list, and the three oldest ones, have just one or two items in the Note History Action Menu. Those four all have an identical timestamp in the newest item in the NHAM; the second newest has a timestamp one minute earlier.

Anyway, seems like possibly some combination of issues. For one, not sure how so many copies got made; I'd expect two e.g. new unsynced one on phone vs. older copy, but not five. And then, not sure if separate or the source of the dupes in the first place, the inconsistencies with tags and note history.

I didn't edit / delete any of the dupes yet in case it may be helpful to get you any further info on this. Let me know.

@mobitar

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Sync conflicts in general don't keep count. If there is a conflict, a duplicate will unconditionally be made. Sync conflicts occur if the date of the item you are trying to save is different from the date the server has. In this case, it's likely that there were some dropped requests when you were saving from mobile, causing a date mismatch. And indeed, only the original note will have the full note history, as history is tracked by note id, and duplicates get a new id. This issue isn't really disconcerting, but it is inconvenient. We'll definitely want to improve on this in some way in the future.

@bschlagel

This comment has been minimized.

Copy link
Author

commented Aug 31, 2019

Ah okay thanks for clarifying! Yeah I guess I was on a shaky mobile connection and a few duplicates got queued up behind the scenes but I only noticed when I got home an opened the app again.

Maybe still something to look into here re: tags — not sure why the original (note w/ full history) and two of the dupes have the correct tags, but the other two dupes ended up with no tags at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.