Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've created a web clipper! #704

Open
johnjones4 opened this issue Sep 29, 2019 · 13 comments

Comments

@johnjones4
Copy link

commented Sep 29, 2019

Something I've wished this great product offered was a web clipper, and I noticed a few people in discussions here seem to desire that as well. Therefore, I took advantage of the great API documentation that the Standard File team offers and built a proof-of-concept web clipper. The add-on works with Chrome and Firefox and let's you select the portion of the page you want to clip. It then adds the HTML content of that selection to your Standard Notes account. But there's much to be done which I need some help with:

  • 2FA Login - I can't seem to find the documentation for this, so you must have 2FA not enabled to try this add-on.
  • Editor Preference - When articles are clipped right now, they show up as HTML in Standard Notes, but if you switch the note to use the Plus Editor, the HTML renders properly. I do not know how to set that editor as the preferred editor when creating the note via the API.
  • Clipping User Experience - The clipping experience is really just a proof of concept, and so there's very little thought given to the user experience of clipping.
  • Tagging - It'd be great to tag clipped articles after saving.
  • Branding - This will be determined by how this fits into the Standard Notes ecosystem, but there's really no look or feel to this add-on.

https://github.com/johnjones4/Standard-Notes-Clipper

@mobitar

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@johnjones4 johnjones4 closed this Sep 30, 2019
@mobitar

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

We can keep this open for visibility :)

@mobitar mobitar reopened this Sep 30, 2019
@johnjones4

This comment has been minimized.

Copy link
Author

commented Oct 1, 2019

Heads up that 2FA Login is working in the extension now

@johnjones4

This comment has been minimized.

Copy link
Author

commented Oct 6, 2019

@mobitar I've built out the clipping experience a bit more. Would love your feedback!

@mobitar

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Very nice! Really like the bordered outline, and the clip confirmation where you can modify title and set tags. The only thing was that I couldn't figure out how to clip a multi-paragraph segment. For example, on this page, the bordered box would only appear on one paragraph at a time, or the entire parent container, which is the whole article. Would it be possible to use traditional text selection as the way to clip?

@johnjones4

This comment has been minimized.

Copy link
Author

commented Oct 7, 2019

Yeah good idea. I could add a slider button that toggles between "Clip Region" and "Clip Highlighted Text".

@johnjones4

This comment has been minimized.

Copy link
Author

commented Oct 8, 2019

@mobitar done! Let me know what you think when you have a moment.

@mobitar

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Works great! The only feedback would be that if I highlight text, then click the extension icon, it should automatically just clip that segment and save it. Currently the extension works best if I click its icon first, then choose the highlight option, then highlight, then clip. So we could say many steps by just highlighting then clicking the icon.

@johnjones4

This comment has been minimized.

Copy link
Author

commented Oct 10, 2019

Done!

@mobitar

This comment has been minimized.

Copy link
Member

commented Oct 15, 2019

Looks great!

@johnjones4

This comment has been minimized.

Copy link
Author

commented Oct 15, 2019

Great! Would love to have a conversation about what folding this into the larger SN project can look like. Again, I'm committed to maintaining this and keeping it open.

@mobitar

This comment has been minimized.

Copy link
Member

commented Oct 16, 2019

I do like seeing you constantly push improvements. I typically expect projects like these to be abandoned, but there's still time for that to happen ;) My main reservation is training users to input their master password anywhere else but our main clients. We don't want to set that precedent. So the only way I'd feel comfortable allowing that is if we transferred repository ownership completely to our domain, and had you (and others who are interested in contributing) maintain it that way. We'd also want to potentially get a designer to take a stab at some of the UI.

Let me know if you can see that working, and how long you imagine you'd be willing to be the main maintainer responsible for this project. And what your incentives are for doing so :)

@johnjones4

This comment has been minimized.

Copy link
Author

commented Oct 16, 2019

Yes I totally understand your concerns here. Long-term engagement with a project is always a question - such is the challenge of most open source projects. The best assurance I can give you is that this is a tool I'm actively using and therefore have a decent amount of skin in the game. I've been a daily SN user for over a year, and I plan on using it for the foreseeable future. Therefore I'd be willing to commit to being the maintainer of this part of the project so long as I use SN.

Additionally, I think your security and UI concerns are totally valid, and I am 100% on board with transferring this project into the SN organization. I also think you should own the account that submits this project to the Google and Firefox extension marketplaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.