Silence Standard warnings by filtering rubocop-rails-only params #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard validates plugin YAML like user config against a temporary, minimal default. rubocop-rails’ default.yml contains two entries that are fine when loaded by RuboCop’s plugin integrator as defaults, but trigger warnings when validated early by Standard. This change drops those from the rules as Standard merges configs for RuboCop - Remove AllCops/MigratedSchemaVersion and nil AllCops/TargetRailsVersion to silence RuboCop param warnings; both deletions are behavior-neutral (epoch default skips nothing; nil TargetRailsVersion lets RuboCop infer Rails version). - Lint/UselessAccessModifier: Standard’s base disables this cop. Removing the rubocop-rails-specific parameters does not enable the cop and has no effect on linting outcomes. Also adds a test that will fail the build if anything prints to stderr Fixes #72
jasonkarns
approved these changes
Sep 23, 2025
czeise
approved these changes
Sep 23, 2025
robsdudeson
approved these changes
Sep 23, 2025
Contributor
|
Any chance for a patch bump to get these warnings silenced ... or are we on verge of another rubocop-rails bump which will pull that along with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard validates plugin YAML like user config against a temporary, minimal default. rubocop-rails’ default.yml contains two entries that are fine when loaded by RuboCop’s plugin integrator as defaults, but trigger warnings when validated early by Standard.
This change drops those from the rules as Standard merges configs for RuboCop
Remove AllCops/MigratedSchemaVersion and nil AllCops/TargetRailsVersion to silence RuboCop param warnings; both deletions are behavior-neutral (epoch default skips nothing; nil TargetRailsVersion lets RuboCop infer Rails version).
Lint/UselessAccessModifier: Standard’s base disables this cop. Removing the rubocop-rails-specific parameters does not enable the cop and has no effect on linting outcomes.
Also adds a test that will fail the build if anything prints to stderr
Fixes #72