Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up travis script #4

Open
steveri opened this issue Apr 10, 2017 · 4 comments
Open

Clean up travis script #4

steveri opened this issue Apr 10, 2017 · 4 comments
Assignees

Comments

@steveri
Copy link
Contributor

steveri commented Apr 10, 2017

Pat recommended (and I agree) that we clean up the travis script by wrapping each flow stage into a called or sourced shell script e.g. instead of

  - git clone https://github.com/jeffsetter/Halide_CoreIR.git
  - export CXX=${CXX_}
  - export CC=${CC_}
  - export LLVM_CONFIG=${TRAVIS_BUILD_DIR}/llvm/bin/llvm-config
  - export CLANG=${TRAVIS_BUILD_DIR}/llvm/bin/clang
  - export CORECONFIG="g++-4.9"
  - export COREIR_DIR=${TRAVIS_BUILD_DIR}/coreir

it might read something like

  - echo "INSTALL COREIR"
  - git clone https://github.com/jeffsetter/Halide_CoreIR.git
  - echo "Setup env vars (CXX, CC, LLVM_CONFIG...)"
  - source Halide_CoreIR/.travis_before_install.sh

Also, there seems to be some leftover script bits that are not directly related to the current CGRA flow, e.g. see below. Could someone (James?) please verify that these are no longer required and if so maybe remove them. Thanks!

> before_install:
>   - echo "INSTALL RIGEL"
>   - git clone https://github.com/jameshegarty/rigel.git
>   - export PKG_CONFIG_PATH=${TRAVIS_BUILD_DIR}/rigel/platform/verilator
>   - pkg-config --cflags verilator
>   - pkg-config --variable=includedir verilator
> 
> script:
>    # coreir
>   - cd coreir/tests
>   - ./run
>   - pytest  # Test python bindings
>   - cd ../..
>   
>     # rigel
>   - cd rigel/examples
>   - make out/pointwise_wide_handshake.verilator.bmp
>   - cd ../../

@jameshegarty
Copy link
Member

Sounds like a good plan, I will work on this.

@jeffsetter
Copy link
Contributor

I've worked on cleaning up the halide portion of this. Let me know if you have suggestions on a better way than I've done my changes.

@steveri
Copy link
Contributor Author

steveri commented Apr 11, 2017 via email

@jameshegarty
Copy link
Member

I remove that stuff, but the build is breaking for other reasons. I think we should have a discussion on Tues.

@jeffsetter jeffsetter removed their assignment Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants