Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claude does not work with the new experimental setting. #1271

Open
Xargonus opened this issue Jul 11, 2024 · 2 comments
Open

Claude does not work with the new experimental setting. #1271

Xargonus opened this issue Jul 11, 2024 · 2 comments

Comments

@Xargonus
Copy link

Using Claude lm with the new experimental setting (new_generate) causes the following error:

TypeError: Messages.create() got an unexpected keyword argument 'stop'
@arnavsinghvi11
Copy link
Collaborator

Hi @Xargonus , thanks for raising this. The new experimental setting does configure the stop condition, but this may not be applicable for all supported LM providers.

I am not familiar with the latest Claude API, but a fix could be assigning the value of stop to Claude's equivalent of a stopping condition and removing stop before the request is sent. Feel free to open a PR to correct this within anthropic.py.

@lsickert
Copy link

lsickert commented Aug 6, 2024

Just a heads-up that this also applies to the AwsAnthropic module. The correct parameter for Anthropic would be stop_sequences. Maybe it could be an idea to parameterize this inside of the new_generate function so that it will work with all language model providers.

@okhat okhat added the LM Issues label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants