Docs Update: Minor Update to the order of concepts and renames #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It looks good for the most part but this might break google index in the short term, so I suggest to add some redirection links in mkdocs Check #1681 for reference Thank you so much for the contribution!! |
Contributor
Author
Good call. This PR does not actually change the links. I verified it and it keeps the old links. I just added one redirect for the assertions doc inside deep-dive section which was duplicated so I removed it and added a redirect for it. |
Collaborator
|
Awesome! LGTM 🚢 Thank you so much for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another incremental minor update for the sake of better clarity. Shown below the pre post of the changes. Happy to revert back anything you feel is unnecessary. Also, these changes DO NOT affect the permalinks so it won't cause any breakages to existing links on the internet.
This PR also removes the duplicate
assertions.mdfile inside modules as the same doc is available at the top level under concepts.