-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add pyproject.toml, github action for compiling.
#254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new GitHub Actions workflow file, `build_package.yml`, which is responsible for building the package. The workflow is triggered on pushes to the `main` branch and pull requests. It runs on the latest version of Ubuntu. The workflow uses Poetry version 1.6.1. It sets up the Python environment using the specified Python version (3.9 in this case). It also caches the Poetry installation and the virtual environment to improve build times. The workflow installs the project dependencies using Poetry and then builds the package. It also tests installing the built package and tests importing the package. The commit also includes the addition of a `pyproject.toml` file. This file specifies the build system requirements, project metadata, Python version compatibility, and project dependencies. The dependencies include various packages such as `backoff`, `joblib`, `openai`, `pandas`, `regex`, `ujson`, `tqdm`, `datasets`, `requests`, and `optuna`. Optional dependencies are also specified for packages like `pinecone-client`, `qdrant-client`, `fastembed`, `chromadb`, and `marqo`. Additionally, there are dependencies for building the documentation using Sphinx. The `pyproject.toml` file also includes project metadata such as the project name, version, description, authors, license, and homepage. The purpose of these changes is to automate the package build process and specify the project dependencies and metadata in a standardized way.
…env to simplify workflow and improve reliability fix(build_package.yml): fix missing newline at end of file to adhere to coding conventions
…istency with other files in the repository
699ab7f to
73f1161
Compare
|
lgtm |
okhat
reviewed
Jan 4, 2024
pyproject.toml
Outdated
| homepage = "https://github.com/stanfordnlp/dsp" | ||
| documentation = "https://dspy-ai.readthedocs.io" | ||
| repository = "https://github.com/stanfordnlp/dsp" | ||
| keywords = ["dsp", "ai", "signal processing"] |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has a few hallucinated pieces (signal processing and dspy-ai.readthedocs.io don't exist here haha).
Collaborator
|
Thanks a lot @darinkishore ! This is on the right track but some things are off. Also did we check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #154
Goals: Allow poetry integration. Setup documentation dependencies, allow dev dependencies to be added in future. PEP-compliant.
Also adds github action to ensure project can compile/build, dependencies are installed properly.