Fixing claude v2 in AWS Bedrock #745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@xiaochuan-du - take a look at pull request #751 . I have expanded on the bare bones aws support in the old bedrock.py. Also refactored design into providers vs models. Suggest you add your fixes there |
Author
Contributor
|
@xiaochuan-du - yes, I found some issues while testing. I will resubmit today |
Contributor
|
Hey Kevin,
Here's the new PR after bug fixes - #772
…________________________________
From: Kevin Du ***@***.***>
Sent: Tuesday, April 2, 2024 4:14 AM
To: stanfordnlp/dspy ***@***.***>
Cc: Dhar Rawal ***@***.***>; Mention ***@***.***>
Subject: Re: [stanfordnlp/dspy] Fixing claude v2 in AWS Bedrock (PR #745)
Hey @drawal1<https://github.com/drawal1> , #751<#751> is closed. Are you planning to create another pull request for the update?
—
Reply to this email directly, view it on GitHub<#745 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3F2UHFMUX53HNBZ4T3MH2LY3KAJ5AVCNFSM6AAAAABFRDWNTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRGQ3TSOBTGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
claudetobedrock-claudefor AWS Bedrock Claude to distinguish between AWS Bedrock Claude and the Anthropic Claude clients.bedrock-claude.