Fix pyproject.toml to include package data #7869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
TomeHirata
changed the title
chenmoneygithub
approved these changes
Feb 27, 2025
Collaborator
chenmoneygithub
left a comment
chenmoneygithub
left a comment
There was a problem hiding this comment.
thanks for the PR! LGTM
| include = ["dspy*"] | ||
| where = ["."] | ||
| include = ["dspy", "dspy.*"] | ||
| exclude = ["tests", "tests.*"] |
Collaborator
There was a problem hiding this comment.
curious - since we do explicit include, do we still need this exclude part?
Non-blocking, feel free to merge!
Collaborator
Author
There was a problem hiding this comment.
That's not necessary (I confirmed "tests" are not included when removing this line), but mostly for the safeguard. We do the same configuration in mlflow: https://github.com/mlflow/mlflow/blob/master/pyproject.release.toml#L139
glesperance
pushed a commit
to glesperance/dspy
that referenced
this pull request
Mar 3, 2025
* fix pyproject.toml Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7853 and #7490 without causing #7867.
Confirmed the behavior by running
python -m buildon a clean clone of the DSPy repo.