Fixes and removes non-existent dependency on dsp.SentenceTransformersVectorizer from KNN and KNNFewShot #7884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom KNN and KNNFewShot and fixes and re-enables all tests.
Collaborator
chenmoneygithub
left a comment
chenmoneygithub
left a comment
There was a problem hiding this comment.
Thanks for the PR, it's a very solid work!
Left some comments for readability improvements, the functionality looks good to me!
Contributor
Author
|
Thanks! Should have resolved all comments. PTAL. |
cezarc1
commented
Mar 1, 2025
Contributor
Author
There was a problem hiding this comment.
I ran the linter but it seems to have run it against the whole file. It did find lots of fixes.... I can revert if need be but I think this should be done regardless.
Collaborator
There was a problem hiding this comment.
no worries, I will push a commit to fix it
chenmoneygithub
approved these changes
Mar 1, 2025
Collaborator
There was a problem hiding this comment.
no worries, I will push a commit to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and removes the now non-existent dependency on
dsp.SentenceTransformersVectorizerfromKNNand indirectly fromKNNFewShot.Also:
trainsetandvalsetparams from theKNNFewShot.compilecall as they were unused.