New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
less error #51
Comments
@amelon I don't mind making this change, but I want to make sure these still work - have you been able to confirm this inside of Internet Explorer? Thanks for your contribution! |
Sorry I missed interpolation. Here new solution found on boostrap
And here result:
|
Hmm, the last change you pasted seemed to generate the correct filters - maybe I'm missing something? https://github.com/stanlemon/jGrowl/blob/master/jquery.jgrowl.css#L37-L38 |
I think you missed less variable in css file :( result in css with first exemple
note the result in css with second exemple
here |
Had a similar error with SCSS. When pushing to production we got:
in the So we had to change It ought to be fixed in the jgrowl source, in case other people run into the same problem, and to avoid regression error when updating the library (thus overwriting the fix). |
Alright, I think this is fixed and it's been tagged. I'm curious why when I was running my grunt commands I wasn't seeing the issue you guys were running into. I'm pretty green-with LESS/SCSS so any pointers on how I can catch stuff like this in the future would be very appreciated! Thanks for your contributions! |
Awesome @stanlemon :) I'm not sure. Maybe grunt doesn't pick it up/analyze those kinds of errors in CSS files. I'm not sure how to test for it, I'm afraid. Maybe using this linter (syntax checker) in grunt would help: https://www.npmjs.com/package/grunt-scss-lint |
Hi,
I have an issue with following lines in
jgrowl.core.less
could you enclose them with ~"" like this
The text was updated successfully, but these errors were encountered: