From 94e9afbcb464ab3aaae4b618bafe727535020392 Mon Sep 17 00:00:00 2001 From: Nicolas Neubauer Date: Wed, 2 Apr 2025 13:01:37 +0100 Subject: [PATCH 1/3] Add OrderStatusCode values to reflect failure modes for orders --- stapi-pydantic/src/stapi_pydantic/order.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/stapi-pydantic/src/stapi_pydantic/order.py b/stapi-pydantic/src/stapi_pydantic/order.py index 9ed02c8..feea290 100644 --- a/stapi-pydantic/src/stapi_pydantic/order.py +++ b/stapi-pydantic/src/stapi_pydantic/order.py @@ -43,6 +43,13 @@ class OrderStatusCode(StrEnum): tasked = "tasked" user_canceled = "user_canceled" + pending = "pending" + in_progress = "in_progress" + pending_cancellation = "pending_cancellation" + expired = "expired" + requested = "requested" + failed = "failed" + class OrderStatus(BaseModel): timestamp: AwareDatetime From 1ac1b44effdfd887bc62a4d7c7c951673fde0525 Mon Sep 17 00:00:00 2001 From: Nicolas Neubauer Date: Wed, 2 Apr 2025 14:45:40 +0100 Subject: [PATCH 2/3] reduce number of new states --- stapi-pydantic/src/stapi_pydantic/order.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/stapi-pydantic/src/stapi_pydantic/order.py b/stapi-pydantic/src/stapi_pydantic/order.py index feea290..2c068d5 100644 --- a/stapi-pydantic/src/stapi_pydantic/order.py +++ b/stapi-pydantic/src/stapi_pydantic/order.py @@ -43,12 +43,12 @@ class OrderStatusCode(StrEnum): tasked = "tasked" user_canceled = "user_canceled" - pending = "pending" - in_progress = "in_progress" - pending_cancellation = "pending_cancellation" + # pending = "pending" # task awaiting execution but after start time , could be "scheduled" + # in_progress = "in_progress" # task awaiting execution, could "scheduled" + # pending_cancellation = "pending_cancellation" # going to call this "user_cancelled" + # requested = "requested" # mapping to received expired = "expired" - requested = "requested" - failed = "failed" + failed = "failed" # these two could just map to a shared "failed" state, but that is missing imo class OrderStatus(BaseModel): From 7b7e32eddfec0a740831cab84980dc88a6a9a3f7 Mon Sep 17 00:00:00 2001 From: Pete Gadomski Date: Thu, 3 Apr 2025 14:56:17 +0100 Subject: [PATCH 3/3] feat: add expired and failed --- stapi-pydantic/src/stapi_pydantic/order.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/stapi-pydantic/src/stapi_pydantic/order.py b/stapi-pydantic/src/stapi_pydantic/order.py index 2c068d5..2ea7c50 100644 --- a/stapi-pydantic/src/stapi_pydantic/order.py +++ b/stapi-pydantic/src/stapi_pydantic/order.py @@ -42,13 +42,8 @@ class OrderStatusCode(StrEnum): reserved = "reserved" tasked = "tasked" user_canceled = "user_canceled" - - # pending = "pending" # task awaiting execution but after start time , could be "scheduled" - # in_progress = "in_progress" # task awaiting execution, could "scheduled" - # pending_cancellation = "pending_cancellation" # going to call this "user_cancelled" - # requested = "requested" # mapping to received expired = "expired" - failed = "failed" # these two could just map to a shared "failed" state, but that is missing imo + failed = "failed" class OrderStatus(BaseModel):