Permalink
Commits on Mar 3, 2012
  1. Improved the split script

    kohsuke committed Mar 3, 2012
  2. Backporting a fix for htmlunit

    > commit 6d081fafc40f8b60bbdfb3bc2a7b8f830b8c1ed7
    > Author: Kohsuke Kawaguchi <kk@kohsuke.org>
    > Date:   Fri Sep 23 19:42:21 2011 -0700
    
        This property can be null causing HtmlUnit to fail.
    
        In event-debug.js, there's an overloaded toString() method.
    
            toString: function() {
                 return "CustomEvent: " + "'" + this.type  + "', " +
                     "context: " + this.scope;
    
            }
    
        When the problem happens, "this.scope" points to a DataSourceBase object, and apparently at that time this._sName is null, and it causes a failure in ScriptableObject.getDefaultValue(), at the final "fall through to error" portion (see below)
    
        ----
        Enclosed exception:
        net.sourceforge.htmlunit.corejs.javascript.EcmaError: TypeError: Cannot find default value for object. (http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js#385)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.constructError(ScriptRuntime.java:3652)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.constructError(ScriptRuntime.java:3630)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.typeError(ScriptRuntime.java:3658)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.typeError1(ScriptRuntime.java:3670)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:829)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:748)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.add(ScriptRuntime.java:2558)
        	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.do_add(Interpreter.java:3060)
        	at script.(http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js:385)
        	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:879)
        	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:164)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:808)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:748)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.add(ScriptRuntime.java:2558)
        	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.do_add(Interpreter.java:3060)
        	at script.(http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js:114)
        	at script.(http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js:2258)
        	at script.(http://localhost:46994/static/43c91e29/scripts/yui/datasource/datasource-debug.js:79)
        	at script.(http://localhost:46994/static/43c91e29/scripts/yui/datasource/datasource-debug.js:2302)
        	at script.(http://localhost:46994/static/43c91e29/scripts/yui/autocomplete/autocomplete-debug.js:18)
        	at script.createSearchBox(http://localhost:46994/static/43c91e29/scripts/hudson-behavior.js:1711)
        	at script.(script in http://localhost:46994//login from (4, 3626) to (4, 3663):4)
        	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:879)
        	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:164)
        	at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.doTopCall(ContextFactory.java:427)
        	at com.gargoylesoftware.htmlunit.javascript.HtmlUnitContextFactory.doTopCall(HtmlUnitContextFactory.java:263)
        	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3058)
        	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.exec(InterpretedFunction.java:175)
        	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$5.doRun(JavaScriptEngine.java:415)
        	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:522)
        	at net.sourceforge.htmlunit.corejs.javascript.Context.call(Context.java:529)
        	at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.call(ContextFactory.java:536)
        	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.execute(JavaScriptEngine.java:424)
        	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.execute(JavaScriptEngine.java:399)
        	at com.gargoylesoftware.htmlunit.html.HtmlPage.executeJavaScriptIfPossible(HtmlPage.java:892)
        	at com.gargoylesoftware.htmlunit.html.HtmlScript.executeInlineScriptIfNeeded(HtmlScript.java:309)
        	at com.gargoylesoftware.htmlunit.html.HtmlScript.executeScriptIfNeeded(HtmlScript.java:364)
        	at com.gargoylesoftware.htmlunit.html.HtmlScript$1.execute(HtmlScript.java:223)
        	at com.gargoylesoftware.htmlunit.html.HtmlScript.onAllChildrenAddedToPage(HtmlScript.java:238)
        ----
    
        So this quick fix gets us around.
    
        I think the root cause of the problem is that ScriptableObject.getDefaultValue() should treat null as the primitive value, but I'm bit scared to make that change right now.
    
    diff --git a/war/src/main/webapp/scripts/yui/datasource/datasource-debug.js b/war/src/main/webapp/scripts/yui/datasource/datasource-debug.js
    index 6038175..135c81f 100644
    --- a/war/src/main/webapp/scripts/yui/datasource/datasource-debug.js
    +++ b/war/src/main/webapp/scripts/yui/datasource/datasource-debug.js
    @@ -717,7 +717,7 @@ cloneBeforeCaching : false,
      * @return {String} Unique name of the DataSource instance.
      */
     toString : function() {
    -    return this._sName;
    +    return this._sName || "";
     },
    
     /**
    kohsuke committed Mar 3, 2012
  3. Add '2in3/' from commit '5a01c0b7c1ae17ef56b8a713b1fdc3fdb369f8c4'

    git-subtree-dir: 2in3
    git-subtree-mainline: cbafc45
    git-subtree-split: 5a01c0b
    kohsuke committed Mar 3, 2012
  4. scrap submodule

    kohsuke committed Mar 3, 2012
Commits on Mar 2, 2012
  1. Packaging script

    kohsuke committed Mar 2, 2012
Commits on Apr 19, 2011
  1. put 2.9.0 in the right place

    Adam Moore committed Apr 19, 2011
Commits on Apr 14, 2011
  1. Updated for release 2.9.0

    Adam Moore committed Apr 14, 2011
Commits on Mar 11, 2011
  1. 0.0.5 contains 2.9.0pr1.2725 test wrappers

    Adam Moore committed Mar 11, 2011
  2. Updated wrapper generator scripts. Added YUI src. Added YUI 2.9.0pr1.…

    …2725
    Adam Moore committed Mar 11, 2011
Commits on Oct 28, 2010
  1. Package version bump

    davglass committed Oct 28, 2010
Commits on Oct 26, 2010
  1. 2.8.2 is 2.8.2r1

    Adam Moore committed Oct 26, 2010
  2. 2.8.2 is the 2.8.2r1 release

    Adam Moore committed Oct 26, 2010
  3. added 2.8.2

    Adam Moore committed Oct 26, 2010
Commits on Sep 16, 2010
Commits on Sep 15, 2010
  1. custom wrappers for certain modules. generateId now creates unique id…

    …s across multiple instances.
    Adam Moore committed Sep 15, 2010
Commits on Sep 14, 2010
  1. Relatve paths to CSS assets

    Adam Moore committed Sep 14, 2010
Commits on Sep 13, 2010
  1. .gitignore

    Adam Moore committed Sep 13, 2010
  2. Updated package version

    davglass committed Sep 13, 2010
  3. Added top-level assets directories

    Adam Moore committed Sep 13, 2010
Commits on Sep 10, 2010
  1. Adding package information

    davglass committed Sep 10, 2010
Commits on May 10, 2010
  1. The submodule definition for rollups correctly handle submodule

    requests.  Rolled back the window/document sandbox
    Adam Moore committed May 10, 2010
Commits on May 6, 2010
  1. Added 2in3.1 2.8.1

    Adam Moore committed May 6, 2010
Commits on Apr 27, 2010
  1. 2.8.0 is 2.8.0r4.

    Adam Moore committed Apr 27, 2010
Commits on Apr 26, 2010
  1. Moved source

    Adam Moore committed Apr 26, 2010
  2. Initial commit

    Adam Moore committed Apr 26, 2010